From 4f762b376f80304a0596708165ab92ec9843b93c Mon Sep 17 00:00:00 2001
From: Gazook89 <58999374+Gazook89@users.noreply.github.com>
Date: Sun, 13 Nov 2022 12:45:31 -0600
Subject: [PATCH] tweak validation rules on Thumbnail & prevent invalid field
 from block valid fields

---
 client/homebrew/editor/metadataEditor/metadataEditor.jsx | 2 +-
 client/homebrew/editor/metadataEditor/validations.js     | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/client/homebrew/editor/metadataEditor/metadataEditor.jsx b/client/homebrew/editor/metadataEditor/metadataEditor.jsx
index d98a15113..9073106e8 100644
--- a/client/homebrew/editor/metadataEditor/metadataEditor.jsx
+++ b/client/homebrew/editor/metadataEditor/metadataEditor.jsx
@@ -65,7 +65,7 @@ const MetadataEditor = createClass({
 				[name] : validationErr.length > 0 ? validationErr : undefined
 			}
 		}), ()=>{
-			if(Object.values(this.state.errs ?? {}).filter(Boolean).length === 0 || !this.state.errs[name]){
+			if(validationErr.length === 0){
 				e.target.setCustomValidity('');
 				this.props.onChange({
 					...this.props.metadata,
diff --git a/client/homebrew/editor/metadataEditor/validations.js b/client/homebrew/editor/metadataEditor/validations.js
index ca7504e27..22f9e918b 100644
--- a/client/homebrew/editor/metadataEditor/validations.js
+++ b/client/homebrew/editor/metadataEditor/validations.js
@@ -14,6 +14,7 @@ module.exports = {
 			return value?.length > 256 ? 'Max URL length of 256 characters.' : null;
 		},
 		(value)=>{
+			if(value?.length == 0){return null;}
 			try {
 				Boolean(new URL(value));
 				return null;