f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-05 12:22:44 +00:00
Code Wiki Activity

Linting, small cleanup, and renaming some functions

Browse Source 
Renamed "makeActive" and "renderButton" to make more clear without needing comments.
This commit is contained in:
Trevor Buckner
2024-04-09 11:35:30 -04:00
parent ed85f77c48
commit 4f0cbd82d4
1 changed files with 8 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
client/homebrew/pages/accountPage/accountPage.jsx
View File

@@ -1,8 +1,6 @@
const React = require('react'); const React = require('react');
const moment = require('moment'); const moment = require('moment');
const UIPage = require('../basePages/uiPage/uiPage.jsx'); const UIPage = require('../basePages/uiPage/uiPage.jsx');
const NaturalCritIcon = require('naturalcrit/svg/naturalcrit.svg.jsx'); const NaturalCritIcon = require('naturalcrit/svg/naturalcrit.svg.jsx');
let SAVEKEY = ''; let SAVEKEY = '';
@@ -11,7 +9,6 @@ const AccountPage = (props)=>{
// destructure props // destructure props
const { accountDetails, brew } = props; const { accountDetails, brew } = props;
// State for the save location // State for the save location
const [saveLocation, setSaveLocation] = React.useState(''); const [saveLocation, setSaveLocation] = React.useState('');
@@ -19,15 +16,15 @@ const AccountPage = (props)=>{
React.useEffect(()=>{ React.useEffect(()=>{
if(!saveLocation && accountDetails.username) { if(!saveLocation && accountDetails.username) {
SAVEKEY = `HOMEBREWERY-DEFAULT-SAVE-LOCATION-${accountDetails.username}`; SAVEKEY = `HOMEBREWERY-DEFAULT-SAVE-LOCATION-${accountDetails.username}`;
// if no SAVEKEY in local storage, default save location to Google Drive. // if no SAVEKEY in local storage, default save location to Google Drive if user has Google account.
let saveLocation = window.localStorage.getItem(SAVEKEY); let saveLocation = window.localStorage.getItem(SAVEKEY);
saveLocation = saveLocation ?? (accountDetails.googleId ? 'GOOGLE-DRIVE' : 'HOMEBREWERY'); saveLocation = saveLocation ?? (accountDetails.googleId ? 'GOOGLE-DRIVE' : 'HOMEBREWERY');
makeActive(saveLocation); setActiveSaveLocation(saveLocation);
} }
}, []); }, []);
// function to set the active save location // function to set the active save location
const makeActive = (newSelection)=>{ const setActiveSaveLocation = (newSelection)=>{
if(saveLocation === newSelection) return; if(saveLocation === newSelection) return;
window.localStorage.setItem(SAVEKEY, newSelection); window.localStorage.setItem(SAVEKEY, newSelection);
setSaveLocation(newSelection); setSaveLocation(newSelection);
@@ -35,15 +32,10 @@ const AccountPage = (props)=>{
// render a button for setting save locations. // render a button for setting save locations.
// todo: should this be a set of radio buttons (well styled) since it's either/or choice? // todo: should this be a set of radio buttons (well styled) since it's either/or choice?
const renderButton = (name, key, shouldRender = true)=>{ const renderSaveLocationButton = (name, key, shouldRender = true)=>{
if(!shouldRender) return null; if(!shouldRender) return null;
return ( return (
<button <button className={saveLocation === key ? 'active' : ''} onClick={()=>{setActiveSaveLocation(key);}}>
className={saveLocation === key ? 'active' : ''}
onClick={()=>{
makeActive(key);
}}
>
{name} {name}
</button> </button>
); );
@@ -77,8 +69,8 @@ const AccountPage = (props)=>{
</div> </div>
<div className='dataGroup'> <div className='dataGroup'>
<h4>Default Save Location</h4> <h4>Default Save Location</h4>
{renderButton('Homebrewery', 'HOMEBREWERY')} {renderSaveLocationButton('Homebrewery', 'HOMEBREWERY')}
{renderButton('Google Drive', 'GOOGLE-DRIVE', accountDetails.googleId)} {renderSaveLocationButton('Google Drive', 'GOOGLE-DRIVE', accountDetails.googleId)}
</div> </div>
</> </>
); );