From 8dde0e37edc09ea37573da0a5a2c1ff5060e110c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Losada=20Hern=C3=A1ndez?= Date: Tue, 20 Oct 2026 12:41:11 +0200 Subject: [PATCH 1/4] simplify functions and reorder imports --- .../editor/metadataEditor/metadataEditor.jsx | 41 +++++++------------ 1 file changed, 14 insertions(+), 27 deletions(-) diff --git a/client/homebrew/editor/metadataEditor/metadataEditor.jsx b/client/homebrew/editor/metadataEditor/metadataEditor.jsx index d713c1cc9..b347f3f25 100644 --- a/client/homebrew/editor/metadataEditor/metadataEditor.jsx +++ b/client/homebrew/editor/metadataEditor/metadataEditor.jsx @@ -2,13 +2,14 @@ import '../uiEditor.less'; import React, { useState } from 'react'; import _ from 'lodash'; -import request from '../../utils/request-middleware.js'; -import Combobox from '@components/combobox.jsx'; -import TagInput from '../tagInput/tagInput.jsx'; +import request from '../../utils/request-middleware.js'; import Themes from '@themes/themes.json'; import validations from './validations.js'; +import Combobox from '@components/combobox.jsx'; +import TagInput from '../tagInput/tagInput.jsx'; + import homebreweryThumbnail from '../../thumbnail.png'; const callIfExists = (val, fn, ...args)=>{ @@ -31,20 +32,12 @@ const MetadataEditor = ({ theme : '5ePHB', lang : 'en', }, - onChange = ()=>{}, reportError = ()=>{}, ...props })=>{ const [showThumbnail, setShowThumbnail] = useState(true); - const toggleThumbnailDisplay = ()=>{ - setShowThumbnail(!showThumbnail); - }; - const renderThumbnail = ()=>{ - if(!showThumbnail) return; - return ; - }; const handleFieldChange = (name, e)=>{ // load validation rules, and check input value against them const inputRules = validations[name] ?? []; @@ -141,18 +134,6 @@ const MetadataEditor = ({ ; } }; - const renderDelete = ()=>{ - if(!metadata.editId) return; - - return
- -
- -
-
; - }; const renderAuthors = ()=>{ const authors = metadata.authors; const isOwner = global.account?.username && global.account?.username === authors[0]; @@ -296,7 +277,6 @@ const MetadataEditor = ({ }} /> - ; }; const renderRenderOptions = ()=>{ @@ -364,13 +344,13 @@ const MetadataEditor = ({ /> - {renderThumbnail()} + {showThumbnail && }
@@ -431,7 +411,14 @@ const MetadataEditor = ({
- {renderDelete()} + {metadata.editId &&
+ +
+ +
+
} ); }; From 12941d38a31575619448f41702fc908898f31381 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Losada=20Hern=C3=A1ndez?= Date: Tue, 20 Oct 2026 12:44:36 +0200 Subject: [PATCH 2/4] specifically pass used props --- client/homebrew/editor/metadataEditor/metadataEditor.jsx | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/client/homebrew/editor/metadataEditor/metadataEditor.jsx b/client/homebrew/editor/metadataEditor/metadataEditor.jsx index b347f3f25..6dd88fc22 100644 --- a/client/homebrew/editor/metadataEditor/metadataEditor.jsx +++ b/client/homebrew/editor/metadataEditor/metadataEditor.jsx @@ -34,7 +34,8 @@ const MetadataEditor = ({ }, onChange = ()=>{}, reportError = ()=>{}, - ...props + userThemes = {}, + themeBundle = {} })=>{ const [showThumbnail, setShowThumbnail] = useState(true); @@ -185,7 +186,7 @@ const MetadataEditor = ({ ); }; const renderThemeDropdown = ()=>{ - const mergedThemes = _.merge(Themes, props.userThemes); + const mergedThemes = _.merge(Themes, userThemes); const listThemes = (renderer)=>{ return _.map(_.values(mergedThemes[renderer]), (theme)=>{ @@ -206,7 +207,7 @@ const MetadataEditor = ({ }; const currentRenderer = metadata.renderer; - const currentThemeDisplay = props.themeBundle?.name ? `${props.themeBundle.author ?? currentRenderer} : ${props.themeBundle.name}` : 'No Theme Selected'; + const currentThemeDisplay = themeBundle?.name ? `${themeBundle.author ?? currentRenderer} : ${themeBundle.name}` : 'No Theme Selected'; let dropdown; if(currentRenderer == 'legacy') { From 4b01edd4be82420b813d8ed89cfbba16ffa3ace2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Losada=20Hern=C3=A1ndez?= Date: Tue, 20 Oct 2026 12:46:49 +0200 Subject: [PATCH 3/4] reorder props to match schema --- .../editor/metadataEditor/metadataEditor.jsx | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/client/homebrew/editor/metadataEditor/metadataEditor.jsx b/client/homebrew/editor/metadataEditor/metadataEditor.jsx index 6dd88fc22..01d9b081a 100644 --- a/client/homebrew/editor/metadataEditor/metadataEditor.jsx +++ b/client/homebrew/editor/metadataEditor/metadataEditor.jsx @@ -20,17 +20,18 @@ const callIfExists = (val, fn, ...args)=>{ const MetadataEditor = ({ metadata = { - editId : null, shareId : null, + editId : null, title : '', description : '', - thumbnail : '', tags : [], - published : false, - authors : [], - renderer : 'legacy', - theme : '5ePHB', lang : 'en', + renderer : 'legacy', + authors : [], + published : false, + thumbnail : '', + theme : '5ePHB', + }, onChange = ()=>{}, reportError = ()=>{}, From edae652e528203644f89f626c6e3617c0f394b3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Losada=20Hern=C3=A1ndez?= Date: Tue, 20 Oct 2026 12:52:22 +0200 Subject: [PATCH 4/4] lint 1 --- .../homebrew/editor/metadataEditor/metadataEditor.jsx | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/client/homebrew/editor/metadataEditor/metadataEditor.jsx b/client/homebrew/editor/metadataEditor/metadataEditor.jsx index 01d9b081a..d5c4387e9 100644 --- a/client/homebrew/editor/metadataEditor/metadataEditor.jsx +++ b/client/homebrew/editor/metadataEditor/metadataEditor.jsx @@ -31,7 +31,6 @@ const MetadataEditor = ({ published : false, thumbnail : '', theme : '5ePHB', - }, onChange = ()=>{}, reportError = ()=>{}, @@ -85,13 +84,11 @@ const MetadataEditor = ({ const handleTheme = (theme)=>{ metadata.renderer = theme.renderer; metadata.theme = theme.path; - onChange(metadata, 'theme'); }; const handleThemeWritein = (e)=>{ const shareId = e.target.value.split('/').pop(); //Extract just the ID if a URL was pasted in metadata.theme = shareId; - onChange(metadata, 'theme'); }; const handleLanguage = (languageCode)=>{ @@ -354,7 +351,6 @@ const MetadataEditor = ({ {showThumbnail && } -
@@ -370,17 +366,12 @@ const MetadataEditor = ({ />
- {renderLanguageDropdown()} - {renderThemeDropdown()} - {renderRenderOptions()}

Authors

- {renderAuthors()} -
@@ -400,7 +391,6 @@ const MetadataEditor = ({

Privacy

-
@@ -412,7 +402,6 @@ const MetadataEditor = ({
- {metadata.editId &&