From 3c3b4d8466ffa09efbdba23981167446a986eac7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?V=C3=ADctor=20Losada=20Hern=C3=A1ndez?=
 <losada.hernandez.victor@gmail.com>
Date: Thu, 3 Oct 2024 09:00:57 +0200
Subject: [PATCH] "Updated mock implementation for deleting a notification in
 admin API test"

---
 server/notifications.model.js | 34 ++++++++++++++++++++++------------
 1 file changed, 22 insertions(+), 12 deletions(-)

diff --git a/server/notifications.model.js b/server/notifications.model.js
index f0bb4b400..9da675332 100644
--- a/server/notifications.model.js
+++ b/server/notifications.model.js
@@ -11,40 +11,50 @@ const NotificationSchema = new mongoose.Schema({
 }, { versionKey: false });
 
 NotificationSchema.statics.addNotification = async function(data) {
-	if(!data.dismissKey) return 'Dismiss key is required!';
+	if(!data.dismissKey) return { success: false, message: 'Dismiss key is required!' };
+
 	const defaults = {
 		title   : '',
 		text    : '',
 		startAt : new Date(),
-		stopAt  : new Date()
+		stopAt  : new Date(),
 	};
-	_.defaults(data, defaults);
-	const newNotification = new this(data);
+
+	const notificationData = _.defaults(data, defaults);
+
+	if(!(notificationData.startAt instanceof Date) || !(notificationData.stopAt instanceof Date)) {
+		return { success: false, message: 'Invalid date format for startAt or stopAt' };
+	}
+
 	try {
+		const newNotification = new this(notificationData);
 		const savedNotification = await newNotification.save();
-		return savedNotification;
+		return { success: true, notification: savedNotification };
 	} catch (err) {
-		throw new Error(err.message || 'Error saving notification');
+		return { success: false, message: err.message || 'Error saving notification' };
 	}
 };
 
 NotificationSchema.statics.deleteNotification = async function(dismissKey) {
-	if(!dismissKey) return 'No key provided!';
+	if(!dismissKey) return { success: false, message: 'No key provided!' };
+
 	try {
 		const deletedNotification = await this.findOneAndDelete({ dismissKey }).exec();
-		if(!deletedNotification) throw new Error('Notification not found');
-		return deletedNotification;
+		if(!deletedNotification) {
+			return { success: false, message: 'Notification not found' };
+		}
+		return { success: true, notification: deletedNotification };
 	} catch (err) {
-		throw new Error(err.message || 'Error deleting notification');
+		return { success: false, message: err.message || 'Error deleting notification' };
 	}
 };
 
 NotificationSchema.statics.getAll = async function() {
 	try {
 		const notifications = await this.find().exec();
-		return notifications;
+		return { success: true, notifications };
 	} catch (err) {
-		throw new Error(err.message || 'Error retrieving notifications');
+		return { success: false, message: err.message || 'Error retrieving notifications' };
 	}
 };