From 3825bcbbfbaf78b50491482b7d9c0293075be5c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Losada=20Hern=C3=A1ndez?= Date: Sat, 31 Aug 2024 18:41:36 +0200 Subject: [PATCH] "Simplified brewsQuery construction in buildBrewsQuery function" --- server/vault.api.js | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/server/vault.api.js b/server/vault.api.js index 1ebfa50e2..996ccf536 100644 --- a/server/vault.api.js +++ b/server/vault.api.js @@ -36,15 +36,14 @@ const handleErrorResponse = (res, error, functionName) => { }; const buildBrewsQuery = (legacy, v3) => { - //first off, no need to include renderers, if all are valid + const brewsQuery = { published: true }; if (legacy === 'true' && v3 === 'true') return { published: true }; - const renderers = []; - if (legacy === 'true') renderers.push('legacy'); - if (v3 === 'true') renderers.push('V3'); - - const brewsQuery = { published: true }; - brewsQuery.renderer = { $in: renderers }; + if (legacy === 'true' && v3 !== 'true') { + brewsQuery.renderer = 'legacy'; + } else if (v3 === 'true' && legacy !== 'true') { + brewsQuery.renderer = 'V3'; + } return brewsQuery; };