From 30430cb8cbcf43032df3a14b9c6283f647d9f339 Mon Sep 17 00:00:00 2001
From: "G.Ambatte" <sean@robertson-family.nz>
Date: Mon, 7 Apr 2025 08:36:33 +1200
Subject: [PATCH] Refactor /admin/lock/review/request

---
 server/admin.api.js | 40 ++++++++++++++++++++--------------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/server/admin.api.js b/server/admin.api.js
index 45e8ecc57..dbfe4bc5c 100644
--- a/server/admin.api.js
+++ b/server/admin.api.js
@@ -257,31 +257,31 @@ router.get('/api/lock/reviews', mw.adminOnly, async (req, res)=>{
 router.put('/admin/lock/review/request/:id', async (req, res)=>{
 	// === This route is NOT Admin only ===
 	// Any user can request a review of their document
-	try {
-		const filter = {
-			shareId : req.params.id,
-			lock    : { $exists: 1 }
-		};
+	const filter = {
+		shareId : req.params.id,
+		lock    : { $exists: 1 }
+	};
 
-		const brew = await HomebrewModel.findOne(filter);
-		if(!brew) { return res.json({ status: 'NOT LOCKED', detail: `Brew ID ${req.params.id} is not locked!` }); };
+	const brew = await HomebrewModel.findOne(filter);
+	if(!brew) { return res.json({ status: 'NOT LOCKED', detail: `Brew ID ${req.params.id} is not locked!` }); };
 
-		if(brew.lock.reviewRequested){
-			// console.log(`Review already requested for brew ${brew.shareId} - ${brew.title}`);
-			return res.json({ status: 'ALREADY REQUESTED', detail: `Review already requested for brew ${brew.shareId} - ${brew.title}` });
-		};
+	if(brew.lock.reviewRequested){
+		// console.log(`Review already requested for brew ${brew.shareId} - ${brew.title}`);
+		return res.json({ status: 'ALREADY REQUESTED', detail: `Review already requested for brew ${brew.shareId} - ${brew.title}` });
+	};
 
-		brew.lock.reviewRequested = new Date();
-		brew.markModified('lock');
+	brew.lock.reviewRequested = new Date();
+	brew.markModified('lock');
 
-		await brew.save();
+	await brew.save()
+		.catch((error)=>{
+			console.error(error);
+			return res.json({ status: 'ERROR', detail: `Unable to set request for review on brew ID ${req.params.id}`, error });
+		});
+
+	// console.log(`Review requested on brew ${brew.shareId} - ${brew.title}`);
+	return res.json({ status: 'REVIEW REQUESTED', detail: `Review requested on brew ID ${brew.shareId} - ${brew.title}` });
 
-		// console.log(`Review requested on brew ${brew.shareId} - ${brew.title}`);
-		return res.json({ status: 'REVIEW REQUESTED', detail: `Review requested on brew ID ${brew.shareId} - ${brew.title}` });
-	} catch (error) {
-		console.error(error);
-		return res.json({ status: 'ERROR', detail: `Unable to set request for review on brew ID ${req.params.id}`, error });
-	}
 });
 
 router.put('/api/lock/review/remove/:id', mw.adminOnly, async (req, res)=>{