f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-09 05:02:42 +00:00
Code Wiki Activity

remove redundant boolean comparison logic

Browse Source
This commit is contained in:
Charlie Humphreys
2022-12-21 16:19:41 -06:00
parent 7c61a27084
commit 2f5bc8db54
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
server/homebrew.api.js
View File

@@ -58,8 +58,8 @@ const getBrew = (accessType, stubOnly = false)=>{
stub = stub ? _.assign({ ...excludeStubProps(stub), stubbed: true }, excludeGoogleProps(googleBrew)) : googleBrew; stub = stub ? _.assign({ ...excludeStubProps(stub), stubbed: true }, excludeGoogleProps(googleBrew)) : googleBrew;
} }
const authorsExist = stub?.authors?.length > 0; const authorsExist = stub?.authors?.length > 0;
const isAuthor = (stub?.authors || [])?.includes(req.account?.username); const isAuthor = stub?.authors?.includes(req.account?.username);
const isInvited = (stub?.invitedAuthors || []).includes(req.account?.username); const isInvited = stub?.invitedAuthors?.includes(req.account?.username);
if(accessType === 'edit' && (authorsExist && (!isAuthor || !isInvited))) { if(accessType === 'edit' && (authorsExist && (!isAuthor || !isInvited))) {
throw `The current logged in user does not have editor access to this brew. throw `The current logged in user does not have editor access to this brew.