f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-21 02:52:43 +00:00
Code Wiki Activity

add callIfExists, which will call a method only if it exists

Browse Source
This commit is contained in:
Charlie Humphreys
2022-12-05 22:06:06 -06:00
parent d7de2e3d21
commit 208593d203
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
client/homebrew/editor/metadataEditor/metadataEditor.jsx
View File

@@ -9,7 +9,7 @@ const Nav = require('naturalcrit/nav/nav.jsx');
const StringArrayEditor = require('../stringArrayEditor/stringArrayEditor.jsx'); const StringArrayEditor = require('../stringArrayEditor/stringArrayEditor.jsx');
const Themes = require('themes/themes.json'); const Themes = require('themes/themes.json');
const validations = require('./validations.js') const validations = require('./validations.js');
const SYSTEMS = ['5e', '4e', '3.5e', 'Pathfinder']; const SYSTEMS = ['5e', '4e', '3.5e', 'Pathfinder'];
@@ -53,7 +53,13 @@ const MetadataEditor = createClass({
}, },
handleFieldChange : function(name, e){ handleFieldChange : function(name, e){
e.persist(); const callIfExists = (val, fn, ...args)=>{
if(val[fn]) {
val[fn](...args);
}
};
callIfExists(e, 'persist');
// load validation rules, and check input value against them // load validation rules, and check input value against them
const inputRules = validations[name] ?? []; const inputRules = validations[name] ?? [];
@@ -61,20 +67,19 @@ const MetadataEditor = createClass({
// if no validation rules, save to props // if no validation rules, save to props
if(validationErr.length === 0){ if(validationErr.length === 0){
e.target.setCustomValidity(''); callIfExists(e.target, 'setCustomValidity', '');
this.props.onChange({ this.props.onChange({
...this.props.metadata, ...this.props.metadata,
[name] : e.target.value [name] : e.target.value
}); });
} else { } else {
// if validation issues, display built-in browser error popup with each error. // if validation issues, display built-in browser error popup with each error.
console.log(validationErr);
const errMessage = validationErr.map((err)=>{ const errMessage = validationErr.map((err)=>{
return `- ${err}`; return `- ${err}`;
}).join('\n'); }).join('\n');
e.target.setCustomValidity(errMessage); callIfExists(e.target, 'setCustomValidity', errMessage);
e.target.reportValidity(); callIfExists(e.target, 'reportValidity');
}; }
}, },
handleSystem : function(system, e){ handleSystem : function(system, e){