f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-15 23:32:41 +00:00
Code Wiki Activity

Remove error prop

Browse Source 
Userpage is never passed `Error` prop from anywhere. Thus we can rename the error state here from `currentError` to just `error`
This commit is contained in:
Trevor Buckner
2024-10-26 22:59:49 -04:00
parent 6f2252635a
commit 1b4d41fc19
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
client/homebrew/pages/userPage/userPage.jsx
View File

@@ -18,11 +18,10 @@ const UserPage = (props)=>{
username : '', username : '',
brews : [], brews : [],
query : '', query : '',
error : null,
...props ...props
}; };
const [currentError, setCurrentError] = useState(props.error || null); const [error, setError] = useState(null);
const usernameWithS = props.username + (props.username.endsWith('s') ? `’` : `’s`); const usernameWithS = props.username + (props.username.endsWith('s') ? `’` : `’s`);
const groupedBrews = _.groupBy(props.brews, (brew)=>brew.published ? 'published' : 'private'); const groupedBrews = _.groupBy(props.brews, (brew)=>brew.published ? 'published' : 'private');
@@ -43,7 +42,7 @@ const UserPage = (props)=>{
const navItems = ( const navItems = (
<Navbar> <Navbar>
<Nav.section> <Nav.section>
{currentError && (<ErrorNavItem error={currentError} parent={null}></ErrorNavItem>)} {error && (<ErrorNavItem error={error} parent={null}></ErrorNavItem>)}
<NewBrew /> <NewBrew />
<HelpNavItem /> <HelpNavItem />
<VaultNavitem /> <VaultNavitem />
@@ -54,7 +53,7 @@ const UserPage = (props)=>{
); );
return ( return (
<ListPage brewCollection={brewCollection} navItems={navItems} query={props.query} reportError={(err)=>setCurrentError(err)} /> <ListPage brewCollection={brewCollection} navItems={navItems} query={props.query} reportError={(err)=>setError(err)} />
); );
}; };