f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-09 07:12:40 +00:00
Code Wiki Activity

If no stub exists, start stub as {}, not undefined

Browse Source 
Recent changes to handle bad brew properties (tags as strings, no renderer, etc.) didn't account for the case where an old Google brew is first being stubbed; since no stub exists, there is no object to perform the corrections on, and we crash.
This commit is contained in:
Trevor Buckner
2023-01-09 14:53:35 -05:00
committed by GitHub
parent 8cbab4d4ce
commit 15e5a31767
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
server/homebrew.api.js
View File

@@ -47,7 +47,7 @@ const api = {
console.warn(err); console.warn(err);
} }
}); });
stub = stub?.toObject(); stub = stub?.toObject() || {};
// If there is a google id, try to find the google brew // If there is a google id, try to find the google brew
if(!stubOnly && (googleId || stub?.googleId)) { if(!stubOnly && (googleId || stub?.googleId)) {
@@ -77,8 +77,8 @@ If you believe you should have access to this brew, ask the file owner to invite
} }
// Clean up brew: fill in missing fields with defaults / fix old invalid values // Clean up brew: fill in missing fields with defaults / fix old invalid values
stub.tags = stub?.tags || undefined; // Clear empty strings stub.tags = stub.tags || undefined; // Clear empty strings
stub.renderer = stub?.renderer || undefined; // Clear empty strings stub.renderer = stub.renderer || undefined; // Clear empty strings
stub = _.defaults(stub, DEFAULT_BREW_LOAD); // Fill in blank fields stub = _.defaults(stub, DEFAULT_BREW_LOAD); // Fill in blank fields
req.brew = stub; req.brew = stub;