From 15ac397b63474e959a09eab53c834b693f3c14c5 Mon Sep 17 00:00:00 2001 From: Rae Che Date: Sun, 27 May 2018 11:55:06 +0100 Subject: [PATCH] Fix inconsistent React state update. Flagged by lgtm.com (as js/react/inconsistent-state-update). --- client/homebrew/brewRenderer/brewRenderer.jsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/client/homebrew/brewRenderer/brewRenderer.jsx b/client/homebrew/brewRenderer/brewRenderer.jsx index e2c87ff8a..07a6bb119 100644 --- a/client/homebrew/brewRenderer/brewRenderer.jsx +++ b/client/homebrew/brewRenderer/brewRenderer.jsx @@ -62,9 +62,9 @@ const BrewRenderer = createClass({ }, handleScroll : function(e){ - this.setState({ - viewablePageNumber : Math.floor(e.target.scrollTop / e.target.scrollHeight * this.state.pages.length) - }); + this.setState((prevState)=>({ + viewablePageNumber : Math.floor(e.target.scrollTop / e.target.scrollHeight * prevState.pages.length) + })); }, shouldRender : function(pageText, index){