From 124d03f8c164f324cd86dba2127fd6d782d1e2ed Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?V=C3=ADctor=20Losada=20Hern=C3=A1ndez?=
 <losada.hernandez.victor@gmail.com>
Date: Fri, 30 Oct 2026 15:35:41 +0100
Subject: [PATCH] Search and or and not

---
 client/homebrew/pages/vaultPage/vaultPage.jsx | 222 ++++++++++++------
 .../homebrew/pages/vaultPage/vaultPage.less   |  41 ++--
 server/vault.api.js                           |  42 +++-
 3 files changed, 207 insertions(+), 98 deletions(-)

diff --git a/client/homebrew/pages/vaultPage/vaultPage.jsx b/client/homebrew/pages/vaultPage/vaultPage.jsx
index 328348893..bfb20bd77 100644
--- a/client/homebrew/pages/vaultPage/vaultPage.jsx
+++ b/client/homebrew/pages/vaultPage/vaultPage.jsx
@@ -45,7 +45,12 @@ const VaultPage = (props)=>{
 	const v3Ref           = useRef(null);
 	const legacyRef       = useRef(null);
 	const submitButtonRef = useRef(null);
-	const [tagsList, setTagList] = useState(props.query.tags.split(',') || []);
+
+	const parseTags = (value)=>value?.split(',').filter(Boolean) || [];
+
+	const [tagsListAnd, setTagListAnd] = useState(parseTags(props.query.tagsAnd));
+	const [tagsListOr, setTagListOr] = useState(parseTags(props.query.tagsOr));
+	const [tagsListNot, setTagListNot] = useState(parseTags(props.query.tagsNot));
 
 	useEffect(()=>{
 		disableSubmitIfFormInvalid();
@@ -65,54 +70,88 @@ const VaultPage = (props)=>{
 		setSearching(false);
 	};
 
-	const updateUrl = (titleValue, authorValue, countValue, v3Value, legacyValue, tagsValue, page, sort, dir)=>{
+
+	const buildQueryParams = (entries)=>{
+		const params = new URLSearchParams();
+
+		entries.forEach(([key, value])=>{
+			if(value === undefined || value === null || value === '') return;
+			if(Array.isArray(value) && value.length === 0) return;
+
+			params.set(key, Array.isArray(value) ? value.join(',') : value);
+		});
+
+		return params.toString();
+	};
+
+
+	const updateUrl = (params)=>{
 		const url = new URL(window.location.href);
-		const urlParams = new URLSearchParams(url.search);
 
-		urlParams.set('title', titleValue);
-		urlParams.set('author', authorValue);
-		urlParams.set('count', countValue);
-		urlParams.set('v3', v3Value);
-		urlParams.set('legacy', legacyValue);
-		urlParams.set('tags', tagsValue);
-		urlParams.set('page', page);
-		urlParams.set('sort', sort);
-		urlParams.set('dir', dir);
+		url.search = params;
 
-
-		console.log(urlParams.toString());
-		url.search = urlParams.toString();
 		window.history.replaceState(null, '', url.toString());
 	};
 
-	const performSearch = async (title, author, count, v3, legacy, tags, page, sort, dir)=>{
-		updateUrl(title, author, count, v3, legacy, tags, page, sort, dir);
 
-		const response = await request
-			.get(`/api/vault?title=${title}&author=${author}&v3=${v3}&legacy=${legacy}&tags=${tags}&count=${count}&page=${page}&sort=${sort}&dir=${dir}`)
-			.catch((error)=>{
-				console.log('error at loadPage: ', error);
-				setError(error);
-				updateStateWithBrews([], 1);
-			});
+	const performSearch = async (formContents, page, sort, dir)=>{
+		const { title, author, count, v3, legacy, tagsAnd, tagsOr, tagsNot } = formContents;
 
-		if(response?.ok)
+
+		const params = buildQueryParams([
+			['title', title],
+			['author', author],
+			['v3', v3],
+			['legacy', legacy],
+			['tagsAnd', tagsAnd],
+			['tagsOr', tagsOr],
+			['tagsNot', tagsNot],
+			['count', count],
+			['page', page],
+			['sort', sort],
+			['dir', dir]
+		]);
+
+		updateUrl(params);
+
+		const response = await request.get(`/api/vault?${params}`)
+        .catch((error)=>{
+        	console.log('error at loadPage: ', error);
+        	setError(error);
+        	updateStateWithBrews([], 1);
+        });
+
+		if(response?.ok) {
 			updateStateWithBrews(response.body.brews, page);
+		}
 	};
 
-	const loadTotal = async (title, author, v3, legacy, tags)=>{
+	const loadTotal = async (formContents)=>{
+		const { title, author, count, v3, legacy, tagsAnd, tagsOr, tagsNot } = formContents;
+
 		setTotalBrews(null);
 
-		const response = await request.get(`/api/vault/total?title=${title}&author=${author}&v3=${v3}&legacy=${legacy}&tags=${tags}`)
-		.catch((error)=>{
-			console.log('error at loadTotal: ');
-			console.error(error);
-			setError(error);
-			updateStateWithBrews([], 1);
-		});
+		const params = buildQueryParams([
+			['title', title],
+			['author', author],
+			['v3', v3],
+			['legacy', legacy],
+			['tagsAnd', tagsAnd],
+			['tagsOr', tagsOr],
+			['tagsNot', tagsNot]
+		]);
 
-		if(response.ok)
+		const response = await request.get(`/api/vault/total?${params}`)
+        .catch((error)=>{
+        	console.log('error at loadTotal: ');
+        	console.error(error);
+        	setError(error);
+        	updateStateWithBrews([], 1);
+        });
+
+		if(response?.ok) {
 			setTotalBrews(response.body.totalBrews);
+		}
 	};
 
 	const loadPage = async (page, updateTotal, sort, dir)=>{
@@ -126,7 +165,14 @@ const VaultPage = (props)=>{
 		const count      = countRef.current.value || 20;
 		const v3         = v3Ref.current.checked != false;
 		const legacy     = legacyRef.current.checked != false;
-		const tags       = tagsList;
+		const tagsAnd    = tagsListAnd;
+		const tagsOr     = tagsListOr;
+		const tagsNot    = tagsListNot;
+
+		const formContents = {
+			title, author, count, v3, legacy, tagsAnd, tagsOr, tagsNot
+		};
+
 		const sortOption = sort || 'title';
 		const dirOption  = dir || 'asc';
 		const pageProp   = page || 1;
@@ -134,10 +180,10 @@ const VaultPage = (props)=>{
 		setSort(sortOption);
 		setdir(dirOption);
 
-		performSearch(title, author, count, v3, legacy, tags, pageProp, sortOption, dirOption);
+		performSearch(formContents, pageProp, sortOption, dirOption);
 
 		if(updateTotal)
-			loadTotal(title, author, v3, legacy, tags);
+			loadTotal(formContents);
 	};
 
 	const renderNavItems = ()=>(
@@ -161,8 +207,9 @@ const VaultPage = (props)=>{
 		const isTitleValid      = titleRef.current.validity.valid && titleRef.current.value;
 		const isAuthorValid     = authorRef.current.validity.valid && authorRef.current.value;
 		const isCheckboxChecked = legacyRef.current.checked || v3Ref.current.checked;
+		const isTagsValid = tagsListAnd.length >= 1 || tagsListOr.length >= 1;
 
-		const isFormValid = (isTitleValid || isAuthorValid) && isCheckboxChecked;
+		const isFormValid = (isTitleValid || isAuthorValid || isTagsValid) && isCheckboxChecked;
 
 		return isFormValid;
 	};
@@ -173,7 +220,7 @@ const VaultPage = (props)=>{
 
 	const renderForm = ()=>(
 		<div className='brewLookup'>
-			<h2 className='formTitle'>Brew Lookup</h2>
+			<h1 className='formTitle'>Brew Lookup</h1>
 			<div className='formContents'>
 				<label>
 					Title of the brew
@@ -210,19 +257,50 @@ const VaultPage = (props)=>{
 					/>
 				</label>
 
-				<label>
-					Tags
-					<TagInput 
-						id='combobox-tags'
-						label='tags' 
-						valuePatterns={/^\s*(?:(?:group|meta|system|type)\s*:\s*)?[A-Za-z0-9][A-Za-z0-9 \/\\.&_\-]{0,40}\s*$/}
-						placeholder='add tag'
-						unique={true}
-						values={tagsList}
-						onChange={(e)=>setTagList(e.target.value)}
-						tooltip='You may start tags with "type", "system", "group" or "meta" followed by a colon ":", these will be colored in your userpage.'
-					/>
-				</label>
+				<h3>Tag Search</h3>
+				<fieldset className='tags'>
+					<label>
+					Must include
+						<TagInput
+							id='combobox-tags-and'
+							label='tags'
+							valuePatterns={/^\s*(?:(?:group|meta|system|type)\s*:\s*)?[A-Za-z0-9][A-Za-z0-9 \/\\.&_\-]{0,40}\s*$/}
+							placeholder='add tag'
+							unique={true}
+							values={tagsListAnd}
+							onChange={(e)=>setTagListAnd(e.target.value)}
+							tooltip='You may start tags with "type", "system", "group" or "meta" followed by a colon ":", these will be colored in your userpage.'
+						/>
+					</label>
+
+					<label>
+					Match any
+						<TagInput
+							id='combobox-tags-or'
+							label='tags'
+							valuePatterns={/^\s*(?:(?:group|meta|system|type)\s*:\s*)?[A-Za-z0-9][A-Za-z0-9 \/\\.&_\-]{0,40}\s*$/}
+							placeholder='add tag'
+							unique={true}
+							values={tagsListOr}
+							onChange={(e)=>setTagListOr(e.target.value)}
+							tooltip='You may start tags with "type", "system", "group" or "meta" followed by a colon ":", these will be colored in your userpage.'
+						/>
+					</label>
+
+					<label>
+					Must exclude
+						<TagInput
+							id='combobox-tags-not'
+							label='tags'
+							valuePatterns={/^\s*(?:(?:group|meta|system|type)\s*:\s*)?[A-Za-z0-9][A-Za-z0-9 \/\\.&_\-]{0,40}\s*$/}
+							placeholder='add tag'
+							unique={true}
+							values={tagsListNot}
+							onChange={(e)=>setTagListNot(e.target.value)}
+							tooltip='You may start tags with "type", "system", "group" or "meta" followed by a colon ":", these will be colored in your userpage.'
+						/>
+					</label>
+				</fieldset>
 
 				<label>
 					Results per page
@@ -270,7 +348,7 @@ const VaultPage = (props)=>{
 				</button>
 			</div>
 			<legend>
-				<h3>Tips and tricks</h3>
+				<h2>Tips and tricks</h2>
 				<ul>
 					<li>
 						Only <b>published</b> brews are searchable via this tool
@@ -332,8 +410,8 @@ const VaultPage = (props)=>{
 			<div className='radio-toggle layout-container'>
 				<h6>View:</h6>
 				<label className='option' title='grid'>
-						<input name='layout-mode' type='radio' onChange={(e)=>handleLayoutChange(e, 'grid')} checked={layoutMode === 'grid'} />
-						<i className='fac compressed-grid'></i>
+					<input name='layout-mode' type='radio' onChange={(e)=>handleLayoutChange(e, 'grid')} checked={layoutMode === 'grid'} />
+					<i className='fac compressed-grid'></i>
 				</label>
 				<label className='option' title='list'>
 					<input name='layout-mode' type='radio' onChange={(e)=>handleLayoutChange(e, 'list')} checked={layoutMode === 'list'} />
@@ -354,31 +432,31 @@ const VaultPage = (props)=>{
 
 	const renderThemePicker = ()=>{
 		return (
-			<div className="radio-toggle theme-container">
+			<div className='radio-toggle theme-container'>
 				<h6>Theme:</h6>
-				<label className="option">
-					<input type="radio" name="theme" onChange={(e)=>handleThemeChange(e, 'light')} checked={themeMode === 'light'}/>
-					<i className="fas fa-sun"/>
+				<label className='option'>
+					<input type='radio' name='theme' onChange={(e)=>handleThemeChange(e, 'light')} checked={themeMode === 'light'}/>
+					<i className='fas fa-sun'/>
 				</label>
-				<label className="option">
-					<input type="radio" name="theme" onChange={(e)=>handleThemeChange(e, 'dark')}  checked={themeMode === 'dark'}/>
-					<i className="fas fa-moon"/>
+				<label className='option'>
+					<input type='radio' name='theme' onChange={(e)=>handleThemeChange(e, 'dark')}  checked={themeMode === 'dark'}/>
+					<i className='fas fa-moon'/>
 				</label>
 			</div>
-		)
+		);
 	};
 
-	
-	const renderNav = () =>{
+
+	const renderNav = ()=>{
 		return (
-			<div className="listPageNav">
+			<div className='listPageNav'>
 				{renderLayoutModeOptions()}
 				{renderThemePicker()}
 				{renderSortOptions()}
 			</div>
 		);
-			
-	}
+
+	};
 
 	const renderPaginationControls = ()=>{
 		if(!totalBrews || totalBrews < 10) return null;
@@ -460,19 +538,19 @@ const VaultPage = (props)=>{
 		}
 
 		if(error) {
-			if(error.HBErrorCode === undefined) { 
+			if(error.HBErrorCode === undefined) {
 				return (
 					<div className='foundBrews noBrews'>
 						<h3>Error: Unknown error</h3>
 					</div>
-				)
+				);
 			} else {
 
 				const errorText = ErrorIndex()[error.HBErrorCode.toString()] || '';
 
 				return (
 					<div className='foundBrews noBrews'>
-					<h3>Error: {errorText}</h3>
+						<h3>Error: {errorText}</h3>
 					</div>
 				);
 			}
@@ -496,7 +574,7 @@ const VaultPage = (props)=>{
 		}
 
 		return (
-			<div className={`foundBrews ${themeMode + 'Mode'}`}>
+			<div className={`foundBrews ${`${themeMode}Mode`}`}>
 				<span className='totalBrews'>
 					{`Brews found: `}
 					<span>{totalBrews}</span>
diff --git a/client/homebrew/pages/vaultPage/vaultPage.less b/client/homebrew/pages/vaultPage/vaultPage.less
index b1375b9b9..fd2b12645 100644
--- a/client/homebrew/pages/vaultPage/vaultPage.less
+++ b/client/homebrew/pages/vaultPage/vaultPage.less
@@ -53,14 +53,31 @@
 				letter-spacing : 2px;
 				color          : var(--h1-clr);
 			}
+
+			h1 {
+				margin        : 20px 0;
+				font-size     : 30px;
+				text-align    : center;
+				border-bottom : 3px solid;
+			}
+
+			h2 {
+				margin-block  : 30px 20px;
+				font-size     : 18px;
+				text-align    : center;
+				border-bottom : 2px solid;
+			}
+
+			h3 {
+				margin-block: 20px 5px;
+				border-bottom:1px solid;
+			}
+
+			fieldset {
+				padding-left:5px;
+			}
 				
 			legend {
-				h3 {
-					margin-block  : 30px 20px;
-					font-size     : 20px;
-					text-align    : center;
-					border-bottom : 2px solid;
-				}
 				ul {
 					padding-inline : 30px 10px;
 					li {
@@ -88,14 +105,6 @@
 			}
 			&:not(:has(input[type='checkbox']:checked))::after { opacity : 1; }
 
-			.formTitle {
-				margin        : 20px 0;
-				font-size     : 30px;
-				color         : black;
-				text-align    : center;
-				border-bottom : 2px solid;
-			}
-
 			.formContents {
 				position       : relative;
 				display        : flex;
@@ -127,12 +136,12 @@
     				display: grid;
 
 					.tagInput-dropdown {
-   						z-index: 400;
+   						z-index: unset;
     					max-width: 200px;
 						
 					}
 				}
-	.list {
+		.list {
 			display   : flex;
 			flex      : 1 0;
 			flex-wrap : wrap;
diff --git a/server/vault.api.js b/server/vault.api.js
index 65b820b33..4f6dd26a3 100644
--- a/server/vault.api.js
+++ b/server/vault.api.js
@@ -29,14 +29,30 @@ const rendererConditions = (legacy, v3)=>{
 	return {}; // If all renderers selected, renderer field not needed in query for speed
 };
 
-const tagConditions = (tags) => {
-    if (!tags || tags.length === 0) return {};
+const tagConditions = (tagsAnd, tagsOr, tagsNot) => {
+    const conditions = {};
 
-    return {
-        $or: tags.map(tag => ({
+	console.log(tagsAnd.length, tagsOr.length, tagsNot.length);
+
+    if (tagsAnd.length > 0) {
+        conditions.$and = tagsAnd.map(tag => ({
             tags: tag.trim()
-        }))
-    };
+        }));
+    }
+
+    if (tagsOr.length > 0) {
+        conditions.$or = tagsOr.map(tag => ({
+            tags: tag.trim()
+        }));
+    }
+
+    if (tagsNot.length > 0) {
+        conditions.$nor = tagsNot.map(tag => ({
+            tags: tag.trim()
+        }));
+    }
+
+    return conditions;
 };
 
 const sortConditions = (sort, dir) => {
@@ -51,16 +67,20 @@ const findBrews = async (req, res)=>{
 	const page   = Math.max(parseInt(req.query.page)  || 1, 1);
 	const count  = Math.max(parseInt(req.query.count) || 20, 10);
 	const skip   = (page - 1) * count;
-	const tags = req.query.tags.split(',') || [];
+	const tagsAnd = req.query.tagsAnd?.split(',') || [];
+	const tagsOr = req.query.tagsOr?.split(',') || [];
+	const tagsNot = req.query.tagsNot?.split(',') || [];
 	const sort = req.query.sort || 'title';
 	const dir = req.query.dir || 'asc';
 
+	console.log(`Title: ${title}, Author: ${author}, page: ${page}, count: ${count}, tagsAnd: ${tagsAnd}, tagsOr: ${tagsOr} tagsNot: ${tagsNot}`);
+
 	const combinedQuery = {
 		$and : [
 			{ published: true },
 			rendererConditions(req.query.legacy, req.query.v3),
 			titleConditions(title),
-			tagConditions(tags),
+			tagConditions(tagsAnd, tagsOr, tagsNot),
 			authorConditions(author)
 		],
 	};
@@ -97,7 +117,9 @@ const findBrews = async (req, res)=>{
 const findTotal = async (req, res)=>{
 	const title  = req.query.title || '';
 	const author = req.query.author || '';
-	const tags = req.query.tags.split(',') || [];
+	const tagsAnd = req.query.tagsAnd?.split(',') || [];
+	const tagsOr = req.query.tagsOr?.split(',') || [];
+	const tagsNot = req.query.tagsNot?.split(',') || [];
 
 	const combinedQuery = {
 		$and : [
@@ -105,7 +127,7 @@ const findTotal = async (req, res)=>{
 			rendererConditions(req.query.legacy, req.query.v3),
 			titleConditions(title),
 			authorConditions(author),
-			tagConditions(tags)
+			tagConditions(tagsAnd, tagsOr, tagsNot)
 		],
 	};