From 34f620c59b68a125dc0f9a737f4c22f99b136be4 Mon Sep 17 00:00:00 2001 From: Sean Robertson Date: Mon, 17 May 2021 12:16:22 +1200 Subject: [PATCH 1/4] Fix 'Share to Reddit' link for Google brews Fix 'Share to Reddit' generating incorrect links for brews stored on Google Drive --- client/homebrew/editor/metadataEditor/metadataEditor.jsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/client/homebrew/editor/metadataEditor/metadataEditor.jsx b/client/homebrew/editor/metadataEditor/metadataEditor.jsx index badd7bfbc..b0889f757 100644 --- a/client/homebrew/editor/metadataEditor/metadataEditor.jsx +++ b/client/homebrew/editor/metadataEditor/metadataEditor.jsx @@ -67,10 +67,12 @@ const MetadataEditor = createClass({ getRedditLink : function(){ const meta = this.props.metadata; + + const shareLink = (meta.googleID ? meta.googleId + meta.shareId : meta.shareId); const title = `${meta.title} [${meta.systems.join(' ')}]`; const text = `Hey guys! I've been working on this homebrew. I'd love your feedback. Check it out. -**[Homebrewery Link](http://homebrewery.naturalcrit.com/share/${meta.shareId})**`; +**[Homebrewery Link](http://homebrewery.naturalcrit.com/share/${shareLink})**`; return `https://www.reddit.com/r/UnearthedArcana/submit?title=${encodeURIComponent(title)}&text=${encodeURIComponent(text)}`; }, From 3b34fe72b9b5daf05c4ce6e56927f9c65e788b2b Mon Sep 17 00:00:00 2001 From: "G.Ambatte" Date: Mon, 17 May 2021 19:23:35 +1200 Subject: [PATCH 2/4] Lint fix. --- client/homebrew/editor/metadataEditor/metadataEditor.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/homebrew/editor/metadataEditor/metadataEditor.jsx b/client/homebrew/editor/metadataEditor/metadataEditor.jsx index b0889f757..ea986d5ac 100644 --- a/client/homebrew/editor/metadataEditor/metadataEditor.jsx +++ b/client/homebrew/editor/metadataEditor/metadataEditor.jsx @@ -67,7 +67,7 @@ const MetadataEditor = createClass({ getRedditLink : function(){ const meta = this.props.metadata; - + const shareLink = (meta.googleID ? meta.googleId + meta.shareId : meta.shareId); const title = `${meta.title} [${meta.systems.join(' ')}]`; const text = `Hey guys! I've been working on this homebrew. I'd love your feedback. Check it out. From 23e773ce641c701c3546df8b5ca59f76306865ac Mon Sep 17 00:00:00 2001 From: "G.Ambatte" Date: Tue, 18 May 2021 16:37:13 +1200 Subject: [PATCH 3/4] Update client/homebrew/editor/metadataEditor/metadataEditor.jsx Co-authored-by: Trevor Buckner --- client/homebrew/editor/metadataEditor/metadataEditor.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/homebrew/editor/metadataEditor/metadataEditor.jsx b/client/homebrew/editor/metadataEditor/metadataEditor.jsx index ea986d5ac..e0ec19374 100644 --- a/client/homebrew/editor/metadataEditor/metadataEditor.jsx +++ b/client/homebrew/editor/metadataEditor/metadataEditor.jsx @@ -68,7 +68,7 @@ const MetadataEditor = createClass({ getRedditLink : function(){ const meta = this.props.metadata; - const shareLink = (meta.googleID ? meta.googleId + meta.shareId : meta.shareId); + const shareLink = (meta.googleID || '') + meta.shareId; const title = `${meta.title} [${meta.systems.join(' ')}]`; const text = `Hey guys! I've been working on this homebrew. I'd love your feedback. Check it out. From 70bdb07c1e59815348e18e1bb9d6c0c3b4dad6c9 Mon Sep 17 00:00:00 2001 From: "G.Ambatte" Date: Wed, 9 Jun 2021 21:42:12 +1200 Subject: [PATCH 4/4] Update client/homebrew/editor/metadataEditor/metadataEditor.jsx Co-authored-by: Trevor Buckner --- client/homebrew/editor/metadataEditor/metadataEditor.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/homebrew/editor/metadataEditor/metadataEditor.jsx b/client/homebrew/editor/metadataEditor/metadataEditor.jsx index e0ec19374..ed9cabcd1 100644 --- a/client/homebrew/editor/metadataEditor/metadataEditor.jsx +++ b/client/homebrew/editor/metadataEditor/metadataEditor.jsx @@ -68,7 +68,7 @@ const MetadataEditor = createClass({ getRedditLink : function(){ const meta = this.props.metadata; - const shareLink = (meta.googleID || '') + meta.shareId; + const shareLink = (meta.googleId || '') + meta.shareId; const title = `${meta.title} [${meta.systems.join(' ')}]`; const text = `Hey guys! I've been working on this homebrew. I'd love your feedback. Check it out.