From 5374d3eba5e4d5b5aa13af2f80c6dd673588bccb Mon Sep 17 00:00:00 2001 From: Trevor Buckner Date: Wed, 18 Nov 2026 19:59:44 +0000 Subject: [PATCH 1/2] Typo with braces --- client/homebrew/pages/basePages/listPage/listPage.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/homebrew/pages/basePages/listPage/listPage.jsx b/client/homebrew/pages/basePages/listPage/listPage.jsx index d986a674e..dd4c4a06f 100644 --- a/client/homebrew/pages/basePages/listPage/listPage.jsx +++ b/client/homebrew/pages/basePages/listPage/listPage.jsx @@ -202,9 +202,9 @@ const ListPage = ({ brewCollection = [{ title: '', class: '', brews: [] }], navI const filterTextTest = brewStrings.includes(testString); // Filter by user selected tags - const filterTagTest = filterTags.every((tag)=>{ + const filterTagTest = filterTags.every((tag)=> Array.isArray(brew.tags) && //TODO: brew.tags should be converted to array at load so we don't have to catch it here - brew.tags.some((brewTag)=>brewTag.toLowerCase() == tag.toLowerCase())} + brew.tags.some((brewTag)=>brewTag.toLowerCase() == tag.toLowerCase()) ); return filterTextTest && filterTagTest; From 609d4e718228b720d2de9e7854fb431e4e87afeb Mon Sep 17 00:00:00 2001 From: Trevor Buckner Date: Wed, 18 Nov 2026 20:17:06 +0000 Subject: [PATCH 2/2] cleanup `renderBrewCollection()` --- .../pages/basePages/listPage/listPage.jsx | 24 +++++++------------ 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/client/homebrew/pages/basePages/listPage/listPage.jsx b/client/homebrew/pages/basePages/listPage/listPage.jsx index dd4c4a06f..7ea0699bf 100644 --- a/client/homebrew/pages/basePages/listPage/listPage.jsx +++ b/client/homebrew/pages/basePages/listPage/listPage.jsx @@ -233,28 +233,21 @@ const ListPage = ({ brewCollection = [{ title: '', class: '', brews: [] }], navI }); }; - const renderBrewCollection = (brewCollection)=>{ - if(brewCollection.length === 0) - return ( -
-

No Brews

-
- ); - return _.map(brewCollection, (brewGroup, idx)=>{ - const sortedBrewGroup = sortedBrewCollection[idx]; + const renderBrewCollection = ()=>{ + if(sortedBrewCollection.length === 0) + return

No Brews

; + + return _.map(sortedBrewCollection, (brewGroup, idx)=>{ const visible = groupVisibility[brewGroup.class]; return (<>

{ - toggleBrewCollectionState(brewGroup.class); - }}> + onClick={()=>toggleBrewCollectionState(brewGroup.class)}> {brewGroup.title || 'No Title'}

- - {visible ? renderBrews(sortedBrewGroup.brews) : <>} + {visible ? renderBrews(brewGroup.brews) : <>}
); }); @@ -318,7 +311,6 @@ const ListPage = ({ brewCollection = [{ title: '', class: '', brews: [] }], navI {renderTagsOptions()} ); - }; return ( @@ -328,7 +320,7 @@ const ListPage = ({ brewCollection = [{ title: '', class: '', brews: [] }], navI {renderNav()}
-
{renderBrewCollection(brewCollection)}
+
{renderBrewCollection()}
);